Skip to content

✨ Bump dependencies for Kubernetes 1.16.2#588

Closed
munnerz wants to merge 1 commit intokubernetes-sigs:masterfrom
munnerz:k8s-116
Closed

✨ Bump dependencies for Kubernetes 1.16.2#588
munnerz wants to merge 1 commit intokubernetes-sigs:masterfrom
munnerz:k8s-116

Conversation

@munnerz
Copy link
Member

@munnerz munnerz commented Sep 7, 2019 •
edited by DirectXMan12
Loading

Bump dependencies for Kubernetes 1.16.2.

This currently pins to the kubernetes-1.16.2 branch.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 7, 2019
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 7, 2019
@DirectXMan12 DirectXMan12 mentioned this pull request Sep 9, 2019
Closed
@alvaroaleman alvaroaleman mentioned this pull request Sep 16, 2019
Merged
@awesomenix
Copy link
Contributor

awesomenix commented Sep 19, 2019

@munnerz checking if its still being worked on, our project is going to update to 1.16 soon, would be helpful if this gets merged.

@ironcladlou ironcladlou mentioned this pull request Sep 24, 2019
Merged
1 task
@marun marun mentioned this pull request Sep 24, 2019
Merged
@marun
Copy link
Contributor

marun commented Sep 25, 2019

@munnerz Please update this PR to target kubernetes-1.16.0. controller-tools has already been updated which leaves controller-runtime as the blocker for those using kubebuilder and wanting to update deps to 1.16.

@marun marun mentioned this pull request Sep 25, 2019
Closed
@enxebre
Copy link
Member

enxebre commented Sep 30, 2019

friendly ping @munnerz :)

This was referenced Sep 30, 2019
Closed
Merged
@gerred gerred mentioned this pull request Oct 4, 2019
Merged
@DirectXMan12 DirectXMan12 mentioned this pull request Oct 10, 2019
Closed
@munnerz
Bump to kubernetes-1.16.2
402e4d3 
Signed-off-by: James Munnelly <james@munnelly.eu>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 25, 2019
@munnerz
Copy link
Member Author

munnerz commented Oct 25, 2019

I've updated this PR to target kubernetes-1.16.2 and rebased on master since Gopkg.* changes 😄

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 25, 2019
@munnerz
Copy link
Member Author

munnerz commented Oct 25, 2019

Ah, seems #618 has already merged, but this at least bumps to the .2 patch release 😅 thanks @enxebre!

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 25, 2019

@munnerz: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-controller-runtime-test 402e4d3 link /test pull-controller-runtime-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@enxebre
Copy link
Member

enxebre commented Oct 25, 2019

I've updated this PR to target kubernetes-1.16.2 and rebased on master since Gopkg.* changes 😄

sweet! probably want to update the PR desc as well

@DirectXMan12
Copy link
Contributor

DirectXMan12 commented Nov 5, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2019
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 5, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DirectXMan12, munnerz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2019
@DirectXMan12 DirectXMan12 changed the title ✨ Bump dependencies for Kubernetes 1.16 ✨ Bump dependencies for Kubernetes 1.16.2 Nov 6, 2019
@DirectXMan12
Copy link
Contributor

DirectXMan12 commented Nov 6, 2019

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 6, 2019
@DirectXMan12
Copy link
Contributor

DirectXMan12 commented Nov 6, 2019

updated the PR desc, but looks like tests are failing

This was referenced Dec 3, 2019
Closed
Closed
@munnerz
Copy link
Member Author

munnerz commented Dec 17, 2019

Closing in favour of #732

@munnerz munnerz closed this Dec 17, 2019
@enxebre enxebre mentioned this pull request Feb 5, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DirectXMan12 DirectXMan12 Awaiting requested review from DirectXMan12

@pwittrock pwittrock Awaiting requested review from pwittrock

Assignees

@DirectXMan12 DirectXMan12

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@munnerz @awesomenix @marun @enxebre @k8s-ci-robot @DirectXMan12